Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust vitest ambient declaration file according to vitest docs #612

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

vorant94
Copy link
Contributor

What:

Changed the way of patching vitest types with jest-dom custom matchers

Why:

The current approach uses @vitest/expect module, which is considered to be internal implementation details by the vitest team according to comments here, so it shouldn't be used to accomplish the goal

How:

New approach follows the latest official vitest documentation. There was also docs fix that I proposed and got approved recently, so the vitest docs website itself isn't reflecting the latest state. To verify that new approach is aligned with docs, you can check this PR

Along the way I removed export {} statement since it isn't needed when there are import statements are present in the same file

Checklist:

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions
  • Ready to be merged

@gnapse gnapse merged commit 06d19ba into testing-library:main Jul 24, 2024
5 checks passed
@gnapse
Copy link
Member

gnapse commented Jul 24, 2024

@all-contributors please add @vorant94 for code

Copy link
Contributor

@gnapse

I've put up a pull request to add @vorant94! 🎉

Copy link

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants