Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade testing environment #1184

Merged
merged 5 commits into from
Dec 29, 2023
Merged

upgrade testing environment #1184

merged 5 commits into from
Dec 29, 2023

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Dec 27, 2023

What:

These changes update the scripts to work with the rewritten Toolbox.

Interop and deep imports from dom-testing-library have been removed and the relevant code has been inlined.
If the simplified error message for invalid arguments turns out to be insufficient, we should consider adding helpers for error messages on the official exports of DTL – e.g. on the config object.

I reverted the swap of the release action because action-release is tested, requires less config for our workflow and defaults to Conventional Commits which allows to signal breaking changes in the commit summary (fix!:). If there are any issues with that action, please tell me and I'll try to fix it.

How:

The builder modules have been removed from Toolbox.
I decided to use esbuild to bundle dependencies and environment setup.
This conflicted with baseUrl: /dev/null in tsconfig which was a nice workaround to prevent IDEs from autocompleting to non-relative paths because the extended config sets baseUrl to ./src. If that turns out to be a problem again, we should probably just remove extends from our base config.

Checklist:

- [ ] Documentation

  • Tests
  • Ready to be merged

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d036279:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d7483f0) 99.46% compared to head (d036279) 99.13%.

Files Patch % Lines
src/utils/misc/getWindow.ts 50.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   99.46%   99.13%   -0.34%     
==========================================
  Files          89       89              
  Lines        2067     2074       +7     
  Branches      701      698       -3     
==========================================
  Hits         2056     2056              
- Misses         11       18       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ph-fritsche ph-fritsche merged commit d036279 into main Dec 29, 2023
3 of 5 checks passed
@ph-fritsche ph-fritsche deleted the upgradeenv branch December 29, 2023 15:49
Copy link

🎉 This PR is included in version 14.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant