Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the database #5244

Merged
merged 14 commits into from
Nov 26, 2020
Merged

Updates the database #5244

merged 14 commits into from
Nov 26, 2020

Conversation

TiviPlus
Copy link
Member

About The Pull Request

About time

tgstation/tgstation#51255 and followups
tgstation/tgstation#50843

Also fixed Midround Stickyban queries apparently failing constantly

Changelog

🆑
fix: Midround Stickybans will now be applied correctly
refactor: The database now uses Rustg instead of BSQL, meaning the server will crash less
config: Added missing config entries to config, as well as an option for players with enough living time to bypass Bunkers
admin: Admins will now be alerted to new players connecting
admin: Improved database voting system
server: Updated SQL schema
/:cl:

@tgstation-server tgstation-server added Administration Alters the administrative tools used in-game. Config Update Changes to server configuration options. Fix Fixes an issue with the game. GitHub Changes GitHub related matters. Refactor Improves underlying code to make systems more modular and functional. SQL ');DROP TABLE Users;-- Tools Changes to the various development tools. labels Nov 13, 2020
@Hughgent
Copy link
Contributor

Save me @spookydonut!

@spookydonut
Copy link
Contributor

@Hughgent @TiviPlus well lets start with it not passing CI

@TiviPlus
Copy link
Member Author

CI fixed

spookydonut
spookydonut previously approved these changes Nov 14, 2020
Copy link
Contributor

@spookydonut spookydonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoever test merges this should be fired from keyholders no matter who they are.

@spookydonut spookydonut added the Do Not TM Current state of the PR would impair the game if tested. label Nov 14, 2020
@spookydonut
Copy link
Contributor

attn: @MrStonedOne

@optimumtact
Copy link
Member

Does pykyzz not have alter perms to the tgmc database?

@spookydonut
Copy link
Contributor

Does pykyzz not have alter perms to the tgmc database?

Psy is on break and basically MIA @optimumtact

@TiviPlus
Copy link
Member Author

@optimumtact @MrStonedOne still waiting

@optimumtact
Copy link
Member

I don't have the permissions necessary to apply procedures/triggers, until I have that I can't help you

Copy link
Member

@MrStonedOne MrStonedOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes applied. please update the changelog to add the ; so downstreams can just copy/paste the entire set of queries without errors.

SQL/database_changelog.txt Outdated Show resolved Hide resolved
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
@TiviPlus
Copy link
Member Author

Woops meant to @spookydonut

@spookydonut spookydonut merged commit e703c23 into tgstation:master Nov 26, 2020
@TiviPlus TiviPlus deleted the database branch November 26, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration Alters the administrative tools used in-game. Config Update Changes to server configuration options. Do Not TM Current state of the PR would impair the game if tested. Fix Fixes an issue with the game. GitHub Changes GitHub related matters. Refactor Improves underlying code to make systems more modular and functional. SQL ');DROP TABLE Users;-- Tools Changes to the various development tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants