Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captain's Charter/Captain can name the station #18333

Merged
merged 3 commits into from
Jun 9, 2016

Conversation

imtakingabreakdontatme
Copy link
Contributor

@imtakingabreakdontatme imtakingabreakdontatme commented Jun 7, 2016

Allows the captain to name the station if he uses the charter within five minutes of round start.

It spawns in his bag.

no kor put it in his office

If I put it in his office then I'm going to put a mindrole check to make sure it's the captain using it. This is meant to be a perk for playing one of the more stressful roles on station, not more loot for assistants when no captain signs up.

And if Chaplain swords taught me anything it's that players are suckers for silly customization perks that make the job feel special.

🆑 Kor
rscadd: The captain now spawns with the station charter, which allows him to name the station.
/:cl:

@silicons
Copy link
Contributor

silicons commented Jun 7, 2016

Welcome to Reactive Teleportation Armor 13.

@imtakingabreakdontatme
Copy link
Contributor Author

I'll job ban people who make bad names sorry Kevinz, immersion must be preserved.

@Iamgoofball
Copy link
Contributor

The Wall #13

@@ -49,6 +49,5 @@


#undef CHALLENGE_TELECRYSTALS
#undef CHALLENGE_TIME_LIMIT
Copy link

@AKlimentyev AKlimentyev Jun 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes as in intentional? How so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reuse the define for the charter

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I see

@Jordie0608
Copy link
Member

I'll job ban people who make bad names sorry Kevinz, immersion must be preserved.

This will need to be clear to them before the inevitable. And we'll need an admin verb to change it back for when they do so anyway.

Also changelog.

@optimumtact optimumtact added the Feature Exposes new bugs in interesting ways label Jun 7, 2016
@PKPenguin321
Copy link
Contributor

One Day While Andy Was 13

@TechnoAlchemisto
Copy link
Contributor

I'll miss the random generation

user << "The crew has already settled into the shift. It probably wouldn't be good to rename the station right now."
return

var/new_name = reject_bad_name( input(user, "What do you want to name [station_name()]? Keep in mind particularly terrible names may attract the attention of your employers.") as text|null )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to allow numbers and special characters here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@coiax
Copy link
Member

coiax commented Jun 7, 2016

Why not just put a check in the New() that if it's five minutes since the station started, it just deletes itself. Then the captain isn't left with a random wizard scroll in their backpack that doesn't do anything.

@Bawhoppen
Copy link
Contributor

@Jordie0608 there is a rule to use common sense is there not?

@Jordie0608
Copy link
Member

There is. And yesterday I saw a captain named "Noadmin Stimeto Griff". Draw your own conclusion.

if("reset_name")
if(!check_rights(R_ADMIN))
return
world.name = "Space Station 13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either use the initial name of the station or be a "Change Station Name" verb input() which defaults to it.

Copy link
Contributor Author

@imtakingabreakdontatme imtakingabreakdontatme Jun 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you captain station names will be bad just wait until you see admins doing it

user << "The crew has already settled into the shift. It probably wouldn't be good to rename the station right now."
return

var/new_name = input(user, "What do you want to name [station_name()]? Keep in mind particularly terrible names may attract the attention of your employers.") as text|null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm late on this. input() is unsafe, use stripped_input()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dude im embedding a pornhub link as a station nname now dont take this away from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.