Add Sentry #545

thaddeus · 2024-07-20T18:20:51Z

Adds Sentry for the Express server, Cron jobs, and the Manager interface

Merged in the other currently deployed PR

The index file got auto formatted when I saved it - so most of the changes are just formatting. We should add a prettierrc or prettier.config in this and other projects, along with VSCode suggested extensions IMO.

github-actions · 2024-07-20T18:21:03Z

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

👀 Observe the CI jobs and tests to ensure they are passing
✔️ Obtain an approval/review on this pull request
🚀 Branch deploy your pull request to production

Comment .deploy on this pull request to trigger a deploy. If anything goes wrong, rollback with .deploy main
🎉 Merge!

src/tarkov-data-manager/index.mjs

thaddeus · 2024-07-20T18:44:38Z

.deploy

github-actions · 2024-07-20T18:44:54Z

⚠️ Cannot proceed with deployment

reviewDecision: REVIEW_REQUIRED
commitStatus: FAILURE

This is usually caused by missing PR approvals or CI checks failing

Razzmatazzz · 2024-07-25T16:32:36Z

.unlock production

github-actions · 2024-07-25T16:32:54Z

🔓 There is currently no production deployment lock set

Razzmatazzz · 2024-07-25T16:33:20Z

.deploy

github-actions · 2024-07-25T16:33:41Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: add-sentry

github-actions · 2024-07-25T16:37:17Z

Deployment Results ⚠️

Warning: deployment status is unknown, please use caution

Razzmatazzz · 2024-07-25T20:05:38Z

.deploy

github-actions · 2024-07-25T20:05:58Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: add-sentry

github-actions · 2024-07-25T20:07:51Z

Deployment Results ✅

Razzmatazzz successfully deployed branch add-sentry to production

GrantBirki · 2024-07-25T20:20:02Z

.unlock

github-actions · 2024-07-25T20:20:25Z

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

GrantBirki · 2024-07-25T20:21:19Z

.deploy main

github-actions · 2024-07-25T20:21:38Z

Deployment Triggered 🚀

GrantBirki, started a branch deployment to production

You can watch the progress here 🔗

Branch: main

GrantBirki · 2024-07-25T20:21:39Z

Seeing some errors on containers now that this is deployed:

wait-for-it.sh: waiting 15 seconds for database:3306
wait-for-it.sh: database:3306 is available after 0 seconds
[ { 'count(*)': 15 } ]
Database is ready

> tarkov-data-manager@2.0.0 start
> node --max-old-space-size=3000 index.mjs

(node:42) Warning: Accessing non-existent property 'format' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:42) Warning: Accessing non-existent property 'format' of module exports inside circular dependency
TypeError: format is not a function
    at getDbStatement (/app/node_modules/@opentelemetry/instrumentation-mysql2/build/src/utils.js:72:15)
    at PoolConnection.query (/app/node_modules/@opentelemetry/instrumentation-mysql2/build/src/instrumentation.js:65:250)
    at /app/node_modules/mysql2/lib/pool.js:154:14
    at /app/node_modules/mysql2/lib/pool.js:49:37
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
Error refreshing users TypeError: format is not a function
    at getDbStatement (/app/node_modules/@opentelemetry/instrumentation-mysql2/build/src/utils.js:72:15)
    at PoolConnection.query (/app/node_modules/@opentelemetry/instrumentation-mysql2/build/src/instrumentation.js:65:250)
    at /app/node_modules/mysql2/lib/pool.js:154:14
    at /app/node_modules/mysql2/lib/pool.js:68:16
    at PoolConnection.<anonymous> (/app/node_modules/mysql2/lib/connection.js:818:13)
    at Object.onceWrapper (node:events:634:26)
    at PoolConnection.emit (node:events:519:28)
    at ClientHandshake.<anonymous> (/app/node_modules/mysql2/lib/connection.js:137:14)
    at ClientHandshake.emit (node:events:519:28)
    at ClientHandshake.execute (/app/node_modules/mysql2/lib/commands/command.js:49:10) {
  fatal: true
}

tdm@tdm-vm:~$ sudo docker ps
CONTAINER ID   IMAGE                                     COMMAND                  CREATED          STATUS                          PORTS                                                                                                                                    NAMES
d77e8c2195f2   tarkov-data-manager_caddy                 "sh /app/start.sh"       13 minutes ago   Up 7 minutes                    0.0.0.0:80->80/tcp, :::80->80/tcp, 0.0.0.0:443->443/tcp, :::443->443/tcp, 0.0.0.0:8443->8443/tcp, :::8443->8443/tcp, 443/udp, 2019/tcp   caddy-service
81441efa592a   tarkov-data-manager_backup                "docker-entrypoint.s…"   13 minutes ago   Up 7 minutes                                                                                                                                                             tarkov-data-manager_backup_1
77d9007d90c8   tarkov-data-manager_tarkov_data_manager   "docker-entrypoint.s…"   13 minutes ago   Restarting (1) 19 seconds ago                                                                                                                                            tarkov_data_manager
3859740cdf38   tarkov-data-manager_database              "docker-entrypoint.s…"   13 minutes ago   Up 7 minutes                    0.0.0.0:3306->3306/tcp, :::3306->3306/tcp, 33060/tcp                                                                                     tarkov-data-manager_database_1

github-actions · 2024-07-25T20:22:16Z

Deployment Results ✅

GrantBirki successfully deployed branch main to production

GrantBirki · 2024-07-25T20:33:54Z

.unlock

github-actions · 2024-07-25T20:34:16Z

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

Razzmatazzz · 2024-08-05T17:26:09Z

.deploy

github-actions · 2024-08-05T17:26:27Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: add-sentry

github-actions · 2024-08-05T17:27:06Z

Deployment Results ✅

Razzmatazzz successfully deployed branch add-sentry to production

Razzmatazzz · 2024-08-05T17:29:16Z

.deploy main

github-actions · 2024-08-05T17:29:34Z

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: main

github-actions · 2024-08-05T17:30:06Z

Deployment Results ✅

Razzmatazzz successfully deployed branch main to production

Razzmatazzz · 2024-08-05T17:31:30Z

When I deployed this, it appeared to deploy properly, but the data manager never came back online.

thaddeus requested a review from a team as a code owner July 20, 2024 18:20

github-advanced-security bot found potential problems Jul 20, 2024

View reviewed changes

src/tarkov-data-manager/index.mjs Dismissed Show dismissed Hide dismissed

thaddeus and others added 6 commits July 20, 2024 14:36

Add Sentry to data manager and crons

ab91856

Add Sentry to manager interface

d6aee54

fix batching

f867178

improve check-scanners job

dbfd928

batching fixes

27938e8

fix last scan alert

bf35ed1

thaddeus force-pushed the add-sentry branch from 31c5a11 to bf35ed1 Compare July 20, 2024 18:37

Merge branch 'main' into add-sentry

0e40ebc

Razzmatazzz approved these changes Jul 25, 2024

View reviewed changes

github-actions bot had a problem deploying to production July 25, 2024 16:33 Failure

github-actions bot temporarily deployed to production July 25, 2024 20:05 Inactive

Merge branch 'main' into add-sentry

44e1966

github-actions bot temporarily deployed to production August 5, 2024 17:26 Inactive

Razzmatazzz added 2 commits August 12, 2024 11:12

Merge branch 'main' into add-sentry

384af50

Merge branch 'main' into add-sentry

b52b3c2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Sentry #545

Add Sentry #545

thaddeus commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024

thaddeus commented Jul 20, 2024

github-actions bot commented Jul 20, 2024

Razzmatazzz commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

Razzmatazzz commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

Razzmatazzz commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

GrantBirki commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

GrantBirki commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

GrantBirki commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024

GrantBirki commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

Razzmatazzz commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

Razzmatazzz commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

Razzmatazzz commented Aug 5, 2024

Add Sentry #545

Are you sure you want to change the base?

Add Sentry #545

Conversation

thaddeus commented Jul 20, 2024 • edited Loading

github-actions bot commented Jul 20, 2024

👋 Thanks for opening a pull request!

thaddeus commented Jul 20, 2024

github-actions bot commented Jul 20, 2024

⚠️ Cannot proceed with deployment

Razzmatazzz commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

Razzmatazzz commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

Deployment Triggered 🚀

github-actions bot commented Jul 25, 2024

Deployment Results ⚠️

Razzmatazzz commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

Deployment Triggered 🚀

github-actions bot commented Jul 25, 2024

Deployment Results ✅

GrantBirki commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

🔓 Deployment Lock Removed

GrantBirki commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

Deployment Triggered 🚀

GrantBirki commented Jul 25, 2024 • edited Loading

github-actions bot commented Jul 25, 2024

Deployment Results ✅

GrantBirki commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

🔓 Deployment Lock Removed

Razzmatazzz commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

Deployment Triggered 🚀

github-actions bot commented Aug 5, 2024

Deployment Results ✅

Razzmatazzz commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

Deployment Triggered 🚀

github-actions bot commented Aug 5, 2024

Deployment Results ✅

Razzmatazzz commented Aug 5, 2024

thaddeus commented Jul 20, 2024 •

edited

Loading

GrantBirki commented Jul 25, 2024 •

edited

Loading