Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test component set state #109

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Test component set state #109

merged 1 commit into from
Jul 16, 2018

Conversation

bkokoszx
Copy link
Collaborator

I've added UT to comp_set_state function (src/audio/component.c).

lgirdwood
lgirdwood requested changes Jul 16, 2018
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty file and merge commits should be removed from this PR otherwise code is fine.

@bkokoszx
Added comp_set_state function UT's
31599ad 
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx
Copy link
Collaborator Author

I've changed that - now all changes exist in one commit.

@lgirdwood lgirdwood merged commit b9b49ae into thesofproject:master Jul 16, 2018
@jajanusz
Copy link
Contributor

@bkokoszx
Sorry that I'm late to the party but I have 1 note - unit test should fail because of 1 reason - not because of 1 of reasons in array. Like in your tests if you have array with multiple parameter sets you should run unit test for each of these sets instead of test that iterates over all of them - look at alloc tests for example how it should be done.

@lgirdwood
Copy link
Member

@bkokoszx please fix incrementally in a new PR.

@johnylin76 johnylin76 mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkokoszx @jajanusz @lgirdwood