Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume: refine condition in volume_ctrl_get_cmd #126

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

RanderWang
Copy link
Collaborator

@RanderWang RanderWang commented Jul 19, 2018

Fix the check for maximum number of channels to be in the correct range.

Signed-off-by: Rander Wang rander.wang@linux.intel.com

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message and title are too ambiguous, please provide detail of the change. You also cant say max is 8 channels (as it depends on macro).

@RanderWang RanderWang changed the title Volume: fix a typo Volume: refine condition in volume_ctrl_get_cmd Jul 20, 2018
@RanderWang
Copy link
Collaborator Author

Update my commit message

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit title and ID do not match the change. Please use the following.

volume: fix range check for max channels

Fix the check for maximum number of channels to be in the correct range.

SoB.

Fix the check for maximum number of channels to be in the correct range.

Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
@RanderWang RanderWang force-pushed the volume branch 2 times, most recently from 34c27c2 to 070e6bf Compare July 23, 2018 06:40
@RanderWang
Copy link
Collaborator Author

refine the commit message, thanks for review

@lgirdwood lgirdwood merged commit 3a29be9 into thesofproject:master Jul 24, 2018
keqiaozhang pushed a commit to keqiaozhang/sof that referenced this pull request Nov 21, 2018
…nings

logger: added Werror and Wall and removed warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants