-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMA-Trace: fix dma-trace overflow issue #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message needs description of what is done and why.
Please also include the issue number/link, otherwise we cant track.
src/lib/dma-trace.c
Outdated
@@ -391,9 +391,29 @@ void dtrace_event(const char *e, uint32_t length) | |||
|
|||
void dtrace_event_atomic(const char *e, uint32_t length) | |||
{ | |||
struct dma_trace_buf *buffer = NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks exactly like dtrace_event() now without the locking. The purpose of the atomic call is for low frequency and fast trace messages. If we are overflowing then the atomic user is sending too many trace messages and should be converted to verbose_trace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linked to #17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be convert to verbose_trace.
Refine trace log in pm module. There are too many put|get events, so use verbose trace. And atomic trace is for low frequency and fast trace messages Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
This patch look good to me |
Refine dtrace_event_atomic according to dtrace_event
Signed-off-by: Rander Wang rander.wang@linux.intel.com