Topology2: sof-tgl-rt712: remove SDWx from stream name

[bardliao]

The widget name size will exceed the character limit and lead to below error

failed to find module info for widget
alh-copier.SDW0-Playback-SimpleJack.0 with UUID
00000000-0000-0000-0000-000000000000

Shorten the stream name to fix it.

[kv2019i]

@jsarha @ranj063 Can we have a tplg buildtime check for the stream name sizes? That would be a very useful sanity check to have in place.

[jsarha]

Unfortunately I can not easily find from where this limitation comes from, but in any case this a necessary fix.

[ranj063]

The widget name size will exceed the character limit and lead to below error

failed to find module info for widget alh-copier.SDW0-Playback-SimpleJack.0 with UUID 00000000-0000-0000-0000-000000000000

Shorten the stream name to fix it.

@bardliao "alh-copier.SDW0-Playback-SimpleJack.0" is 38 characters and AFAIK the character limit is 44. What am I missing? And you're fixing the stream name but mention that the widget name is too long. very confusing.

[ranj063]

@jsarha @ranj063 Can we have a tplg buildtime check for the stream name sizes? That would be a very useful sanity check to have in place.

@kv2019i I'll take a look

[jsarha]

@jsarha @ranj063 Can we have a tplg buildtime check for the stream name sizes? That would be a very useful sanity check to have in place.

@kv2019i I'll take a look

So limiting factor is SNDRV_CTL_ELEM_ID_NAME_MAXLEN so and its defined 44, right? Bit confusing that CTL ELEM limit applies to other widgets too, or is it all widgets? But in any case, a check somewhere in alsatplg pre-process code should be relatively easy to add. My first instinct would be putting it in the end of tplg_construct_object_name(), but I am not sure about it yet.

However, its still a mystery why a widget with 38 char name gets 00000000-0000-0000-0000-000000000000 UUID.

[bardliao]

I don't know what happened exactly. But the PR does fix the "failed to find module info for widget alh-copier.SDW0-Playback-SimpleJack.0 with UUID 00000000-0000-0000-0000-000000000000" issue.

[bardliao]

I can confirm that alh-copier.DW0-Playback-SimpleJack.0 (length = 36) works but alh-copier.SDW0-Playback-SimpleJack.0 (length = 37) doesn't. I added some trace in kernel. And found that we can't find any array with type = SND_SOC_TPLG_TUPLE_TYPE_UUID in sof_parse_token_sets() in the not working case. Maybe something went wrong in topology?

[kv2019i]

Filed enhancement to track this #9011