Audio: EQ: Tune: Move equalizer setup scripts to module directory #9187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Jun 18, 2024
kv2019i
approved these changes
Aug 26, 2024
| fn.cpath4 = '../../ctl/ipc4/eq_fir'; | ||
| fn.tpath1 = '../../topology/topology1/m4'; | ||
| fn.tpath2 = '../../topology/topology2/include/components/eqfir'; | ||
| sof_tools = '../../../../tools'; |
There was a problem hiding this comment.
This breaks bisect, so ideally should be a single commit. But given these are examples, ok in this case.
There was a problem hiding this comment.
I could combine first two commits. Would that be better?
There was a problem hiding this comment.
I've now combined commits 1 and 2.
|
SOFCI TEST |
The scripts are moved to consolidate the audio modules. The setup tool is common for IIR and FIR where IIR is more commonly used so the destination directory is eq_iir. The equalizers with both IIR and FIR part are also designed in the same run so the design is not split. The paths are fixed in code for new location. There are no other changes. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.