Audio: Multiband-DRC: Move blob configuration scripts to module directory #9216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory To consolidate the audio moves the scripts are moved to the same directory as the module. This first step only moves the files. The next steps rename the scripts and fix possible issue to directories move. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The paths to topology and sof-ctl blobs are updated. The paths to other setup scripts (common, crossover, drc, eq) are set with a new helper function multiband_drc_paths.m. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
approved these changes
Jun 11, 2024
Comment on lines
+12
to
+21
| common = '../../../../tools/tune/common'; | ||
| crossover = '../../../../tools/tune/crossover'; | ||
| drc = '../../../../tools/tune/drc'; | ||
| eq = '../../../../tools/tune/eq'; | ||
| # After #9215 merge use this: | ||
| # crossover = '../../crossover/tune'; | ||
| # After #9188 merge use this: | ||
| # drc = '../../drc/tune'; | ||
| # After #9187 merge use this: | ||
| # eq = '../../eq_iir/tune'; |
There was a problem hiding this comment.
Btw, does Matlab/Octave support PATHs via environment variable ? If so, might be easiest to have a script that sets these for the (like Zephyr has convenience script to setup build environment)
There was a problem hiding this comment.
Yes, the environment variables can be supported:
octave:1> getenv('SOF_WORKSPACE')
ans = /home/singalsu/work/current/sof
Would above be better e.g. as tune = sprintf('%s/sof/tools/tune', getenv('SOF_WORKSPACE')); ?
There was a problem hiding this comment.
Btw, lets track this as a long term feature - ideally long term west would enable this when we configure the environment.
singalsu
requested review from
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
Release reminder - one week to v2.11-rc1. |
cujomalainey
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.