Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volume.h: disable HIFI4 for ACE1.5 #9221

Closed
wants to merge 1 commit into from
Closed

volume.h: disable HIFI4 for ACE1.5 #9221

wants to merge 1 commit into from

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jun 11, 2024

Avoids quality issue #9213.

@marc-hb
volume.h: disable HIFI4 for ACE1.5
9edeb22 
Avoids quality issue thesofproject#9213.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jun 11, 2024

Warning: this has effect on ALL files including volume.h. Currently:

src/audio/volume/volume.c
src/audio/volume/volume.h
src/audio/volume/volume_generic.c
src/audio/volume/volume_generic_with_peakvol.c
src/audio/volume/volume_hifi3.c
src/audio/volume/volume_hifi3_with_peakvol.c
src/audio/volume/volume_hifi4.c
src/audio/volume/volume_hifi4_with_peakvol.c
src/audio/volume/volume_ipc3.c
src/audio/volume/volume_ipc4.c
test/cmocka/src/audio/volume/volume_process.c

To affect only *_with_peakvol.c code, this would have to be moved somewhere.

@marc-hb marc-hb mentioned this pull request Jun 11, 2024
Merged
@marc-hb marc-hb marked this pull request as ready for review June 11, 2024 19:29
@marc-hb marc-hb marked this pull request as draft June 13, 2024 18:28
kv2019i
kv2019i reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably #9208 is better, i.e. disable hifi4 for volume across the board until this is fixed.

src/audio/volume/volume.h
@@ -31,6 +31,12 @@
#include <ipc4/fw_reg.h>
#endif

/* Disable HIFI4, see issue https://github.com/thesofproject/sof/issues/9213 */
#if defined(CONFIG_ACE_VERSION_1_5) && defined(__XCC__)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbernatxintel How about ACE2.0? Should we disable that as well until fix is done?

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jun 14, 2024

#9208 was merged

@marc-hb marc-hb closed this Jun 14, 2024
@marc-hb marc-hb deleted the hifi4-off-ace15 branch June 14, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kv2019i kv2019i kv2019i left review comments

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc-hb @kv2019i