audio: base_fw_intel: Fix problem with send structure ext_system_time_data #9277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbernatxintel
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
gbernatxintel
force-pushed
the
gb_time_rtc_fix
branch
from
95b6c74
to
52e38e6
Compare
gbernatxintel
changed the title
kv2019i
approved these changes
Jul 2, 2024
src/audio/base_fw_intel.c
Outdated
| memcpy_s(ext_system_time, sizeof(ext_system_time), &ext_system_time_data, | ||
| sizeof(ext_system_time)); | ||
| memcpy_s(ext_system_time, sizeof(struct ipc4_ext_system_time), &ext_system_time_data, | ||
| sizeof(struct ipc4_ext_system_time)); |
There was a problem hiding this comment.
I guess "sizeof(ext_system_time_data)" was the original intent ("sizeof(*ext_system_time)" would have done as well). A good catch nevertheless. This is not used by the Linux host so was not caught with Linux driver tests.
There was a problem hiding this comment.
yes, a very good catch, but indeed a
memcpy_s(ext_system_time, sizeof(*ext_system_time), &ext_system_time_data,
sizeof(ext_system_time_data));
would be even better IMHO.
There was a problem hiding this comment.
@lyakh Good point, I changed this line. Thank you
abonislawski
approved these changes
Jul 3, 2024
…_data There was a problem with test test_102_08_extended_time_check. The structure ext_system_time_data was sending with wrong size. Because of this it was not possible to correctly read the value from the art clock to determine the HH counter. Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
gbernatxintel
force-pushed
the
gb_time_rtc_fix
branch
from
52e38e6
to
222a33c
Compare
|
SOFCI TEST |
tmleman
approved these changes
Jul 3, 2024
iuliana-prodan
approved these changes
Jul 3, 2024
lyakh
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with test test_102_08_extended_time_check. The structure ext_system_time_data was sending with wrong size. Because of this it was not possible to correctly read the value from the art clock to determine the HH counter.