Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eradicate -Wl,-EL for good #9353

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Eradicate -Wl,-EL for good #9353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8702353
src/arch/xtensa/CMakeLists.txt: drop bogus, non-portable -Wl,-EL
marc-hb Aug 7, 2024
52f0a51
smex/CMakeLists.txt: drop bogus, non-portable -Wl,-EL binutils option
marc-hb Aug 7, 2024
9226000
tools/plugin: drop bogus -Wl,-EL binutils endianness option
marc-hb Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions smex/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ target_compile_options(smex PRIVATE
)

target_link_options(smex PRIVATE
-Wall -Werror -Wl,-EL
-Wall -Werror
)

target_include_directories(smex PRIVATE
Expand All @@ -36,4 +36,4 @@ if (NOT CONFIG_SOF_ZEPHYR_STRICT_HEADERS)
target_include_directories(smex PRIVATE
"${SOF_ROOT_SOURCE_DIRECTORY}/xtos/include"
)
endif()
endif()
1 change: 0 additions & 1 deletion src/arch/xtensa/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ target_compile_options(sof_options INTERFACE
$<$<COMPILE_LANGUAGE:C>:
-${optimization_flag} -g
-Wall -Werror
-Wl,-EL
-Wmissing-prototypes
-Wpointer-arith
${XTENSA_C_FLAGS}
Expand Down
4 changes: 2 additions & 2 deletions tools/plugin/alsaplug/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ target_include_directories(asound_module_pcm_sof PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/..
${sof_source_directory}/src/audio)

target_compile_options(asound_module_pcm_sof PRIVATE -DPIC -g -O3 -Wl,-EL -Wmissing-prototypes
target_compile_options(asound_module_pcm_sof PRIVATE -DPIC -g -O3 -Wmissing-prototypes
-Wimplicit-fallthrough -DCONFIG_LIBRARY -imacros${config_h})

install(TARGETS asound_module_pcm_sof DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)
Expand Down Expand Up @@ -47,7 +47,7 @@ target_include_directories(asound_module_ctl_sof PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/..
${sof_source_directory}/src/audio)

target_compile_options(asound_module_ctl_sof PRIVATE -DPIC -g -O3 -Wl,-EL -Wmissing-prototypes
target_compile_options(asound_module_ctl_sof PRIVATE -DPIC -g -O3 -Wmissing-prototypes
-Wimplicit-fallthrough -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})

install(TARGETS asound_module_ctl_sof DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)
Expand Down
4 changes: 2 additions & 2 deletions tools/plugin/modules/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ target_include_directories(sof_mod_shm PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/../pipe
${sof_source_directory}/src/audio)

target_compile_options(sof_mod_shm PRIVATE -DPIC -g -O3 -Wl,-EL -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
target_compile_options(sof_mod_shm PRIVATE -DPIC -g -O3 -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})

install(TARGETS sof_mod_shm
DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)
Expand Down Expand Up @@ -39,7 +39,7 @@ target_include_directories(sof_mod_alsa PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/../pipe
${sof_source_directory}/src/audio)

target_compile_options(sof_mod_alsa PRIVATE -DPIC -g -O3 -Wl,-EL -Wmissing-prototypes
target_compile_options(sof_mod_alsa PRIVATE -DPIC -g -O3 -Wmissing-prototypes
-Wimplicit-fallthrough -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})

install(TARGETS sof_mod_alsa
Expand Down
2 changes: 1 addition & 1 deletion tools/plugin/modules/ov_noise_suppression/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ add_library(sof_ns MODULE noise_suppression.c)
target_link_libraries(sof_ns PRIVATE sof_ns_interface)
target_link_libraries(sof_ns PRIVATE -Wl,--export-dynamic)
sof_append_relative_path_definitions(sof_ns)
target_compile_options(sof_ns PRIVATE -DPIC -g -O3 -Wl,-EL -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
target_compile_options(sof_ns PRIVATE -DPIC -g -O3 -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
install(TARGETS sof_ns DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)

target_include_directories(sof_ns PRIVATE
Expand Down
2 changes: 1 addition & 1 deletion tools/plugin/pipe/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ target_include_directories(sof-pipe PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/..
${sof_source_directory}/src/audio)

target_compile_options(sof-pipe PRIVATE -DPIC -g -O3 -Wl,-EL -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
target_compile_options(sof-pipe PRIVATE -DPIC -g -O3 -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})

target_include_directories(sof-pipe PRIVATE ${sof_install_directory}/include)
target_include_directories(sof-pipe PRIVATE ${parser_install_dir}/include)
Expand Down