src: dai-/host-zephyr: Drop the duplicated function name print and print the src/sink frames when there is nothing to copy on dai side #9397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comp_* macros will print the function name from where they are called, there is no need to print them twice. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
… copy' The 'nothing to copy' without context does not help in debugging, print out the number of frames on src and sink side to give some context. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The comp_* macros will print the function name from where they are called, there is no need to print them twice. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
force-pushed
the
peter/pt/dai_host_zephyr_print_cleanup_01
branch
from
b48d065
to
aaa6734
Compare
kv2019i
approved these changes
Aug 23, 2024
| @@ -76,7 +76,7 @@ int dai_assign_group(struct dai_data *dd, struct comp_dev *dev, uint32_t group_i | |||
| { | |||
| if (dd->group) { | |||
| if (dd->group->group_id != group_id) { | |||
| comp_err(dev, "dai_assign_group(), DAI already in group %d, requested %d", | |||
| comp_err(dev, "DAI already in group %d, requested %d", | |||
There was a problem hiding this comment.
This is actually a Zephyr feature (CONFIG_LOG_FUNC_NAME_PREFIX) and not added by SOF comp_() macros, so non-Zephyr targets might still benefit from the function name. But alas, this file is Zephyr specific, so no reason to keep the dual names (and we actually save memory and cycles by reducing these).
There was a problem hiding this comment.
@kv2019i, yes, it is the zephyr prints that does this, thanks for the clarification.
lgirdwood
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comp_* macros will print the function name from where they are called,
there is no need to print them twice.
The context-less 'nothing to copy' print does not give much help to understand why we are not copying.