[ALOY-1535] Remove unnecessary warning message with iOS #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's very small commit, do we need JIRA ticket? |
|
@HazemKhaled, yes please! |
hansemannn
changed the title
|
Here we go: https://jira.appcelerator.org/browse/ALOY-1535 @feons Can you review, merge and adjust the fix-version in the ticket? Thx 🙂 |
|
@hansemannn thanks a lot for the ticket |
|
@HazemKhaled, I think it's still necessary to display a warning when developers try to compile the following for iOS: <AlertDialog id="confirmAlertDialog">
<View>
<Label>This is only for androidView</Label>
</View>
</AlertDialog> |
|
@HazemKhaled Sorry for the late response, but can you adjust the PR to only warn if the |
ewanharris
force-pushed
the
patch-3
branch
2 times, most recently
from
005f55e
to
1facd9c
Compare
|
@feons, I updated the PR to output the warning when the child views are not android only. If you have time could you take a quick look and see if that matches your request. Thanks! |
feons
approved these changes
Mar 19, 2019
On iOS compiling we get warning "Additional views in null only supported on Android" with code
```xml
<AlertDialog id="confirmAlertDialog">
<View platform="android">
<Label>Android only!!</Label>
</View>
</AlertDialog>
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS compiling we get warning
Additional views in null only supported on Androidwith code