Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALOY-1316] Support use of $.args.* in any XML attribute or TSS property #885

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

feons
Copy link
Contributor

@feons feons commented Mar 8, 2018

https://jira.appcelerator.org/browse/ALOY-1316

Not sure if it's a good idea to treat '$.args.*' as an expression. Maybe we should differentiate a string and a js expression when setting properties.

@brentonhouse
Copy link
Contributor

@feons - Checking to see what needs to updated to merge.

@feons
Copy link
Contributor Author

feons commented Feb 27, 2019

@brentonhouse, rebased. Please shower this with some review love!

@brentonhouse
Copy link
Contributor

@ewanharris - Is this PR something we can merge now?

Declaring in the grammar allows using $.args without the quotes, this is more aligned with how the existing usage of Alloy things works in tss files
@ewanharris
Copy link
Contributor

ewanharris commented Mar 11, 2019

@feons, @brentonhouse. I'd noticed an open ticketfrom @Topener about allowing controller created variables to be used in tss, his third suggestion is related to using $ to allow this. What do you think about expanding this PR to allow this usage?

// mapview.js
$.timap = require('ti.map');
 
// mapview.tss
type: $.timap.POLYLINE_PATTERN_DASHED,

Edit: Posted an update on the ticket after looking into it

@brentonhouse
Copy link
Contributor

@ewanharris - sounds good!

@build
Copy link

build commented Jun 6, 2019

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header

Messages
📖

✅ All tests are passing
Nice one! All 3480 tests are passing.

Generated by 🚫 dangerJS against ee3e1a5

@ewanharris ewanharris merged commit ff09b2e into tidev:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants