fix: improve debugging of applications in third party tools and Studio #893

feons · 2018-04-05T22:41:45Z

https://jira.appcelerator.org/browse/ALOY-1612

hansemannn · 2018-04-06T09:19:41Z

Alloy/commands/compile/sourceMapper.js

@@ -117,6 +120,8 @@ exports.generateCodeAndSourceMap = function(generator, compileConfig) {
 	// write the generated controller code
 	var outfile = target.filepath;
 	var relativeOutfile = path.relative(compileConfig.dir.project, outfile);
+	outputResult.code += `\n//# sourceMappingURL=file://${compileConfig.dir.project}/${CONST.DIR.MAP}/${relativeOutfile}.${CONST.FILE_EXT.MAP}`;


It seems like it is not appended to Common JS modules so far. Testing with https://github.com/hansemannn/studentenfutter-app, an advanced Alloy based app. Also, Safari does not seem to pick up the source map so far. Maybe the file:// prefix is invalid there? Testing with Android on Chrome next.

@feons Any update on that one? I've also requested @ewanharris for a QR as he's more into this 😙. Would be good to have source maps working for both iOS and Android, getting it out with the next feature release.

hansemannn · 2018-08-10T09:06:18Z

@feons Can we finish this one?

This check was being performed on the destination file which never existed, we also no longer need to check for a directory here as it is checked prior to calling this function Fixes ALOY-1690

Part of ALOY-1612

build · 2019-05-29T09:42:56Z

	Warnings
⚠️	Please ensure to add a changelog entry for your changes. Edit the `CHANGELOG.md` file and add your change under the `Unreleased items` header

	Messages
📖	✅ All tests are passing Nice one! All 3480 tests are passing.

Generated by 🚫 dangerJS against 236413e

hansemannn · 2019-05-29T11:16:43Z

@ewanharris I see activity here, whooop! :) Let me know if I can test on our larger scale project!

This ensures that the code the the sourcemap is generated lines up a best as we can get with what is handed off to the sdk build process

nirmaljpatel · 2019-06-05T17:32:56Z

Can one of you guide me on how this feature can be used?

For a while I was able to use Safari Developer -> Simulator -> JSContext and see my JS files in the debugger. However, this doesn't seem to be working any more atleast for me with Ti SDK8.0.1.GA.

Is there a guide somewhere elaborating how to debug with Chrome/Safari dev-tools?

…'file' property Fixes ALOY-1691

…ib files

ewanharris · 2019-06-10T13:23:35Z

Hey @nirmaljpatel, this PR is currently going through some changes so I wouldn't recommend using it. We do have guides for debugging iOS via Safari and Android via Chrome, however be aware that for iOS there are currently some known issues TIMOB-27098 with debugging in Safari (which might be what you're referencing?)

…source"

…p as a "source"" This reverts commit 344f41e.

- report absolute path for 'file' property - report absolute path for 'sourceRoot', not a file:// URI - embed sourcesContent for mapped files - fix line counts in source map after hitting template marker lines

sgtcoolguy · 2019-06-17T15:22:43Z

some open TODOs:

We write a source map for app/lib/ files externally, but we do not embed a //# sourceMappingURL= comment in the copied file to point at it. So tools like Babel or node-titanium-sdk don't "know" about the source map.
The whole copying of app/lib/ files is pretty hokey anyways. It copies the file, then we generate a 1:1 source map file (and in the process parse the file unnecessarily!), then after everything the "optimizing" step ends up running the babel transforms on the file when its doing it's sweep on the Resources/ folder. The "copying" portion should do the transform and generate the source map and comment all at once.
We should see if we can't just remove the special babel plugins/transforms altogether in Alloy (and just copy file contents with the source map stuff). I've started to try and move them to a babel plugin here: https://github.com/appcelerator/babel-plugin-transform-titanium that is intended to eventually be used by node-titanium-sdk's jsanalyze method. That way we can just have the same optimizations for all titanium builds and not have special "defines" or optimizations that only Alloy does.

…p sources array

ewanharris

Changes look good to me. Jenkins failure is due to a node connection timeout on the master run but the GA run was fine.

feons requested a review from hansemannn April 5, 2018 22:41

hansemannn reviewed Apr 6, 2018

View reviewed changes

hansemannn requested a review from ewanharris April 12, 2018 15:45

feons and others added 3 commits May 29, 2019 10:04

[ALOY-1612] Be able to use Alloy source-maps in Chrome Dev-Tools

bf13caa

fix: generate sourcemaps for lib files

900be2d

This check was being performed on the destination file which never existed, we also no longer need to check for a directory here as it is checked prior to calling this function Fixes ALOY-1690

feat: add sourceRoot to lib sourcemaps

500fda1

Part of ALOY-1612

ewanharris force-pushed the ALOY-1612 branch from 008f722 to 500fda1 Compare May 29, 2019 09:05

fix: preserve comments and retainLines when optimizing

1fdb643

This ensures that the code the the sourcemap is generated lines up a best as we can get with what is handed off to the sdk build process

ewanharris and others added 3 commits June 6, 2019 20:02

fix: have lib sourcemap report original file for source

86a2133

fix: report the relative path to the generated JS file as source map …

06b3b9c

…'file' property Fixes ALOY-1691

fix: report correct 'sources' and 'file' values for sourcemaps from l…

1177e7d

…ib files

ewanharris mentioned this pull request Jun 12, 2019

source mapping tweaks tidev/node-titanium-sdk#106

Closed

sgtcoolguy added 3 commits June 12, 2019 13:07

fix(sourceMapper): do not include generated file in source map as a "…

344f41e

…source"

Revert "fix(sourceMapper): do not include generated file in source ma…

2b4a52b

…p as a "source"" This reverts commit 344f41e.

fix(sourceMapper): fix generated source maps

67f8e6c

- report absolute path for 'file' property - report absolute path for 'sourceRoot', not a file:// URI - embed sourcesContent for mapped files - fix line counts in source map after hitting template marker lines

fix(sourceMapper): report template source as template.js in source ma…

236413e

…p sources array

ewanharris approved these changes Jun 19, 2019

View reviewed changes

ewanharris merged commit 2190609 into tidev:master Jun 19, 2019

ewanharris changed the title ~~[ALOY-1612] Be able to use Alloy source-maps in Chrome Dev-Tools~~ fix: improve debugging of applications in third party tools and Studio Jun 19, 2019

ewanharris mentioned this pull request Jul 2, 2019

open devtools link within atom tidev/pulsar-titanium#80

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve debugging of applications in third party tools and Studio #893

fix: improve debugging of applications in third party tools and Studio #893

feons commented Apr 5, 2018

hansemannn Apr 6, 2018

hansemannn Apr 12, 2018 •

edited

Loading

hansemannn commented Aug 10, 2018

build commented May 29, 2019 •

edited

Loading

hansemannn commented May 29, 2019

nirmaljpatel commented Jun 5, 2019

ewanharris commented Jun 10, 2019

sgtcoolguy commented Jun 17, 2019

ewanharris left a comment

fix: improve debugging of applications in third party tools and Studio #893

fix: improve debugging of applications in third party tools and Studio #893

Conversation

feons commented Apr 5, 2018

hansemannn Apr 6, 2018

Choose a reason for hiding this comment

hansemannn Apr 12, 2018 • edited Loading

Choose a reason for hiding this comment

hansemannn commented Aug 10, 2018

build commented May 29, 2019 • edited Loading

hansemannn commented May 29, 2019

nirmaljpatel commented Jun 5, 2019

ewanharris commented Jun 10, 2019

sgtcoolguy commented Jun 17, 2019

ewanharris left a comment

Choose a reason for hiding this comment

hansemannn Apr 12, 2018 •

edited

Loading

build commented May 29, 2019 •

edited

Loading