Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile): Define 'state' in ImportDeclaration #947

Merged
merged 1 commit into from
Nov 18, 2019
Merged

fix(compile): Define 'state' in ImportDeclaration #947

merged 1 commit into from
Nov 18, 2019

Conversation

ssjsamir
Copy link
Contributor

ewanharris
ewanharris approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @ssjsamir.

LGTM. I'll merge once Jenkins has ran through

@build
Copy link

build commented Nov 18, 2019

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header
Messages
📖

✅ All tests are passing
Nice one! All 3490 tests are passing.

Generated by 🚫 dangerJS against 8f497f1

@ewanharris ewanharris merged commit 0ec1ca1 into tidev:master Nov 18, 2019
@ewanharris
Copy link
Contributor

Note, the GA SDK test failed due to the Jenkins box using SDK 9, and us running tests under Node.js 8.x which is unsupported in that version. I'll update the Jenkinsfile accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssjsamir @build @ewanharris