-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error messages for incorrect aesthetic mappings #3060
Labels
tidy-dev-day 🤓
Tidyverse Developer Day rstd.io/tidy-dev-day
Comments
I'll work in this for dev-day |
clairemcwhite
added a commit
to clairemcwhite/ggplot2
that referenced
this issue
Jan 19, 2019
clairemcwhite
added a commit
to clairemcwhite/ggplot2
that referenced
this issue
Jan 19, 2019
clauswilke
pushed a commit
that referenced
this issue
Apr 29, 2019
* Clearer error messages for invalid aesthetics Fixes #3060 * closes #3060 * Modified error messages, fixed spacing, right line endings * Replace use of deparse with rlang::as_label * Fix NEWS mispelling and punctuation. layer.R format suggestions * Left in merge >>>, removed * Remove punctuation in test-layer.R that was failing * Add support for multiple problematic aesthetics, fix NEWS.md addition * Change error to display whole problematic phrase, like fill = density * Update tests to be more specific * Fix failing tests, ideally * Another go at test passing * expect_error uses regex, so ( caused failing. Added fixed = TRUE
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I encountered some cryptic error messages that pop up in response to fairly normal user mistakes, where the user maps an aesthetic to a data column that doesn't exist. A better error message could help a lot here.
My code example below first shows the desired output and then two incorrect ways in which a user might try to generate it.
Created on 2019-01-07 by the reprex package (v0.2.1)
The text was updated successfully, but these errors were encountered: