Sample points uniformly from transformed space #2095
Conversation
tests/testthat/test-sec-axis.R
Outdated
| }) | ||
|
|
||
| test_that("custom breaks works", { | ||
| vdiffr::expect_doppelganger( |
There was a problem hiding this comment.
This would be better as a regular test
There was a problem hiding this comment.
All of them or just this one? Don't see how this one differs from the rest...
There was a problem hiding this comment.
I think it's good to have one visual test to ensure the whole process basically works correctly. And then regular tests for everything else.
tests/testthat/test-sec-axis.R
Outdated
| "dup_axis", | ||
| ggplot(foo, aes(x, y)) + | ||
| geom_point() + | ||
| scale_x_continuous(name = "Unit A", |
There was a problem hiding this comment.
Better to set name to NULL here, since it's not germane to the test.
I'd also consider using geom_blank() to help focus on the important part of the visual test
There was a problem hiding this comment.
Sure, that's sloppy copy-pasting from my part
|
@thomasp85 are you interested in finishing this off? Otherwise @karawoo can take a look. |
|
Completely forgot about this one. Sure I'll finish it off👍 |
|
@thomasp85 still interested? |
|
Yep. Sorry, it seems this is constantly slipping out of focus... within the week |
|
Sorry for being slow on this - how is the new tests looking? |
|
Looks good - but I think you need to delete a couple of the generated svgs? |
|
The fail on travis devel is related to stringr and not this PR |
Fixes #1992