Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditching iris #642

Open
mine-cetinkaya-rundel opened this issue Apr 23, 2021 · 1 comment
Open

Ditching iris #642

mine-cetinkaya-rundel opened this issue Apr 23, 2021 · 1 comment
Labels
documentation tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@mine-cetinkaya-rundel
Copy link
Member

The first sheet in datasets.xlsx is iris. Would be good to replace that with another dataset, or just remove it and use the remaining sheets.
@jennybc jennybc added documentation tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day labels May 7, 2021
@jennybc
Copy link
Member

jennybc commented May 7, 2021

Such a swap (e.g. penguins for iris) will affect readxl documentation and perhaps tests, at the very least.

And it's possible that other packages use that file.

So it's a feasible change but not as small as it first looks.

fontikar added a commit to fontikar/readxl that referenced this issue Aug 15, 2024
@fontikar
Remove mention of iris in README files tidyverse#642
3771ebb
@drorberel drorberel mentioned this issue Aug 15, 2024
Open
@fontikar fontikar mentioned this issue Aug 15, 2024
Merged
jennybc added a commit that referenced this issue Aug 16, 2024
@fontikar @jennybc
Don't mention iris dataset in documentation (#752)
35a1905 
* Removed iris from dataset.xlsx

* Removed iris from datasets.xls

* Remove mention of iris in README files #642

* Removed mentioning of iris in vignettes, using mtcars instead

* Updated examples to refer to new mtcars instead of iris

* Updated example to better illustrate example in helpfile

* Whitespace

---------

Co-authored-by: Jenny Bryan <jenny.f.bryan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennybc @mine-cetinkaya-rundel