cpp11 stop in constructor DO NOT MERGE #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #567 I reconfirmed that, in some cases, we can't use `cpp::stop()`, as was previously discovered in 24a8970. (And yet there are also some `cpp11::stop()` calls from a constructor that *do* work fine, such as the one about being unable to retrieve a sheet from a specific position.) In any case, I decided to use plain old `Rf_errorcall()` instead of the stringstream workaround.
This is an example created for r-lib/cpp11#219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a demo for r-lib/cpp11#219.