Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #748

Closed
wants to merge 1 commit into from
Closed

fix typos #748

wants to merge 1 commit into from

Conversation

spaette
Copy link

@spaette spaette commented Jul 31, 2024

per request will attend to the following also

regarding Webinar by @jennybc

$ grep -nr classroms readxl
readxl/talks/2017-05-10_readxl-rstudio-webinar-notes.md:66:  * Bad news: Java. In my experience teaching classroms of ~80 with ~50/50 mix of Mac and Windows, ~30% of students can't get this working immediately on their own. The packages don't merely work poorly or slowly for these students; they simply do not work at all. I'm sure most of these problems can be solved with personalized expert help, but I can't offer that.
$ 

@spaette spaette marked this pull request as ready for review August 1, 2024 23:53
@jennybc
Copy link
Member

jennybc commented Aug 5, 2024

This is vendored code, so I'm not going to take ?automated? suggestions to edit its comments. I feel like we have had a similar conversation before in another repo.

@jennybc jennybc closed this Aug 5, 2024
@spaette
Copy link
Author

spaette commented Aug 5, 2024

vendored code

my apologies


for my own records

the patch (to what appears to be abandonware) had furthermore been flawed

sed -i "s/normalizationis/normalization is/g" src/rapidxml/rapidxml.h
sed -i "s/occured/occurred/g" src/rapidxml/rapidxml.h
sed -i "s/precendence/precedence/g" src/rapidxml/rapidxml.h
sed -i "s/reponsibility/responsibility/g" src/rapidxml/rapidxml.h
sed -i "s/simplyfing/simplifying/g" src/rapidxml/rapidxml.h
sed -i "s/unneded/unneeded/g" src/rapidxml/rapidxml.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants