Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve str_detect documentation (#489) #496

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Improve str_detect documentation (#489) #496

merged 2 commits into from
Jan 19, 2023

Conversation

kylebutts
Copy link
Contributor

@kylebutts kylebutts commented Jan 18, 2023 •
edited
Loading

Fixes #489

@hadley
Copy link
Member

hadley commented Jan 18, 2023

/document

@hadley
Copy link
Member

hadley commented Jan 18, 2023

Thanks for doing this 😄 For future reference, you need Fixes #489 to actually close an issue when a PR is merged.

@kylebutts kylebutts changed the title Improve str_detect documentation (#489) Fixes #489 Jan 18, 2023
@hadley
Copy link
Member

hadley commented Jan 18, 2023

That text needs to go in the PR description not the title; you should use the title as a human readable description of what your PR does.

@kylebutts kylebutts changed the title Fixes #489 Improve str_detect documentation (#489) Jan 18, 2023
@hadley hadley merged commit 65b218e into tidyverse:main Jan 19, 2023
@hadley
Copy link
Member

hadley commented Jan 19, 2023

Thanks!

@kylebutts kylebutts deleted the improve_str_detect branch January 20, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation of str_detect() could be improved
2 participants
@kylebutts @hadley