Prepare release post for ggplot2 3.2.0 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Mar 29, 2019
hadley
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
I think this is good to go once @batpigandme has given it a once over
17 tasks
batpigandme
approved these changes
May 20, 2019
| geom_line(key_glyph = "timeseries") | ||
| ``` | ||
|
|
||
| `geom_rug` has seen a range of improvements to give users more control over the appearance of the rug lines. Now, both the length, as well as whether to position them inside or outside of the plot region can be controlled: |
There was a problem hiding this comment.
Now, both the length, as well as whether to position them inside or outside of the plot region can be controlled
This is a little awkward right now, but I'm not 100% sure how to rephrase, since I'm not sure I understand. My parsing:
The user can newly control two things:
- The length of the rug lines,
- The positioning of the rug lines (inside or outside of the plot region).
If this is correct, then removing the both...as well as construct might help.
There was a problem hiding this comment.
I've tried rewording... let me know if it makes more sense now
Co-Authored-By: Mara Averick <maraaverick@gmail.com>
Co-Authored-By: Mara Averick <maraaverick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.