Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support group with Perl flag setting and non-capturing group #34

Open
elton2048 opened this issue Sep 15, 2024 · 0 comments · May be fixed by #35
Open

Support group with Perl flag setting and non-capturing group #34

elton2048 opened this issue Sep 15, 2024 · 0 comments · May be fixed by #35

Comments

@elton2048
Copy link

I see there is basic support for group but no some more complex features like Perl flag for named group and non-capturing group. It would be good if there is support on that.

I took a look of the code and seems there is no extra attributes for Expr (expression) since that is union(enum). Perhaps it would be a good idea to have new struct Group out such that there could be different attributes like name and captured bool flag to determine the type of that, for further expression handling?

Reference:

elton2048 added a commit to elton2048/zig-regex that referenced this issue Oct 4, 2024
 - Add logic to check the group expression modifiers
 - Implement non-capturing group logic which return `Patch` without
 changing the capture parts responsible for capturing group

Resolve: tiehuis#34
@elton2048 elton2048 linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant