Add column selection to Charges listing #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rissajackson
approved these changes
Aug 18, 2021
| @@ -2,24 +2,36 @@ | |||
| <div> | |||
| <heading class="mb-6">Stripe Dashboard</heading> | |||
|
|
|||
| <balance-card></balance-card> | |||
| <balance-card /> | |||
There was a problem hiding this comment.
Question: What does this do?
There was a problem hiding this comment.
Just a different syntax for a component! Since we don't have any content inside the component tags, it's generally preferred to do this (it's called self-closing).
Here are some more details from the style guide: https://vuejs.org/v2/style-guide/#Self-closing-components-strongly-recommended
Comment on lines
+13
to
+19
| <tr> | ||
| <!-- Id, Amount, Created date, Status--> | ||
| <th v-if="columns" v-for="column in columns" class="text-left"> | ||
| <span class="inline-flex items-center capitalize"> | ||
| {{ column.replaceAll('_', ' ') }} | ||
| </span> | ||
| </th> |
There was a problem hiding this comment.
Praise: This looks so much better and cleaner!
Comment on lines
+26
to
+31
| <td v-for="column in columns"> | ||
| <span v-if="moneyColumns.find(moneyColumn => moneyColumn === column)">{{ charge.currency | money(charge[column]) }}</span> | ||
| <span v-else-if="dateColumns.find(dateColumn => dateColumn === column)">{{ charge[column] | date }}</span> | ||
| <span v-else-if="column === 'status'" class="rounded-lg px-3 py-1 capitalize text-xs font-black" :class="statusClass(charge.status)">{{ charge.refunded ? 'Refunded' : charge.status }}</span> | ||
| <span v-else>{{ charge[column] }}</span> | ||
| </td> |
There was a problem hiding this comment.
Praise: The formats on these look great!
There was a problem hiding this comment.
This is a really clever way to do it!
mattstauffer
approved these changes
Aug 18, 2021
Comment on lines
+26
to
+31
| <td v-for="column in columns"> | ||
| <span v-if="moneyColumns.find(moneyColumn => moneyColumn === column)">{{ charge.currency | money(charge[column]) }}</span> | ||
| <span v-else-if="dateColumns.find(dateColumn => dateColumn === column)">{{ charge[column] | date }}</span> | ||
| <span v-else-if="column === 'status'" class="rounded-lg px-3 py-1 capitalize text-xs font-black" :class="statusClass(charge.status)">{{ charge.refunded ? 'Refunded' : charge.status }}</span> | ||
| <span v-else>{{ charge[column] }}</span> | ||
| </td> |
There was a problem hiding this comment.
This is a really clever way to do it!
Comment on lines
+77
to
+78
| moneyColumns: ['amount', 'amount_captured', 'amount_refunded', 'application_fee_amount', ], | ||
| dateColumns: ['created'], |
|
Fantastic work @faxblaster! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dropdown with checkboxes for all available columns. We're initially loading with our previously static columns (
id,amount,created date, andstatus), but adding the options to select from any of the available data for a Charge.Screenshots
