cluster: fix the bug that region statistics are not updated after flow-round-by-digit change #4304

HunDunDM · 2021-11-08T06:32:44Z

What problem does this PR solve?

fix #4295

What is changed and how it works?

A change in flowRoundDivisor also considers that the flow statistics have changed.

Check List

Tests

Unit test

Code changes

Side effects

Related changes

Need to cherry-pick to the release branch

Release note

Fix the bug that region statistics are not updated after `flow-round-by-digit` change.

…w-round-by-digit change close tikv#4295 Signed-off-by: HunDunDM <hundundm@gmail.com>

Signed-off-by: HunDunDM <hundundm@gmail.com>

ti-chi-bot · 2021-11-08T06:32:46Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

server/core/region.go

codecov · 2021-11-08T06:41:57Z

Codecov Report

Merging #4304 (32652d7) into master (32b9337) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4304      +/-   ##
==========================================
+ Coverage   74.85%   74.89%   +0.03%     
==========================================
  Files         264      264              
  Lines       27255    27257       +2     
==========================================
+ Hits        20402    20413      +11     
+ Misses       5036     5033       -3     
+ Partials     1817     1811       -6

Flag	Coverage Δ
unittests	`74.89% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/core/region.go	`91.82% <100.00%> (+0.01%)`	⬆️
server/core/region_option.go	`82.52% <100.00%> (+0.17%)`	⬆️
server/grpc_service.go	`51.11% <100.00%> (+0.50%)`	⬆️
pkg/errs/errs.go	`75.00% <0.00%> (-25.00%)`	⬇️
server/schedulers/shuffle_hot_region.go	`55.55% <0.00%> (-10.11%)`	⬇️
server/tso/local_allocator.go	`64.86% <0.00%> (-6.76%)`	⬇️
pkg/etcdutil/etcdutil.go	`85.88% <0.00%> (-2.36%)`	⬇️
server/election/leadership.go	`75.25% <0.00%> (-2.07%)`	⬇️
server/schedule/operator_controller.go	`82.68% <0.00%> (-1.23%)`	⬇️
server/tso/global_allocator.go	`60.84% <0.00%> (-1.06%)`	⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b9337...32652d7. Read the comment docs.

server/grpc_service.go

server/core/region_option.go

Signed-off-by: HunDunDM <hundundm@gmail.com>

nolouch

lgtm

HunDunDM · 2021-11-08T08:53:38Z

/merge

ti-chi-bot · 2021-11-08T08:53:39Z

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-11-08T08:53:40Z

This pull request has been accepted and is ready to merge.

Commit hash: 32652d7

ti-chi-bot · 2021-11-08T09:01:42Z

In response to a cherrypick label: new pull request created: #4305.

ti-chi-bot · 2021-11-08T09:02:18Z

In response to a cherrypick label: new pull request created: #4306.

…w-round-by-digit change (#4304) (#4305) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close #4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

ti-chi-bot · 2021-11-12T06:47:24Z

In response to a cherrypick label: new pull request created: #4329.

…w-round-by-digit change (tikv#4304) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close tikv#4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Signed-off-by: hzh0425 <642256541@qq.com>

…w-round-by-digit change (#4304) (#4329) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close #4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

…w-round-by-digit change (#4304) (#4306) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close #4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

HunDunDM added 2 commits November 8, 2021 14:26

cluster: fix the bug that region statistics are not updated after flo…

4e2dc59

…w-round-by-digit change close tikv#4295 Signed-off-by: HunDunDM <hundundm@gmail.com>

refine some code

3662a3a

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM added type/bugfix This PR fixes a bug. component/cluster Cluster logic. needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Nov 8, 2021

HunDunDM requested review from nolouch and rleungx November 8, 2021 06:32

ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 8, 2021

nolouch reviewed Nov 8, 2021

View reviewed changes

server/core/region.go Outdated Show resolved Hide resolved

rleungx reviewed Nov 8, 2021

View reviewed changes

server/grpc_service.go Outdated Show resolved Hide resolved

server/core/region_option.go Show resolved Hide resolved

address comment

32652d7

Signed-off-by: HunDunDM <hundundm@gmail.com>

nolouch approved these changes Nov 8, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021

rleungx approved these changes Nov 8, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021

ti-chi-bot merged commit 7aebe05 into tikv:master Nov 8, 2021

ti-chi-bot mentioned this pull request Nov 8, 2021

cluster: fix the bug that region statistics are not updated after flow-round-by-digit change (#4304) #4305

Merged

ti-chi-bot mentioned this pull request Nov 8, 2021

cluster: fix the bug that region statistics are not updated after flow-round-by-digit change (#4304) #4306

Merged

HunDunDM deleted the fix-keyvis-not-update branch November 8, 2021 09:06

HunDunDM added the needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 label Nov 12, 2021

ti-chi-bot mentioned this pull request Nov 12, 2021

cluster: fix the bug that region statistics are not updated after flow-round-by-digit change (#4304) #4329

Merged

nolouch mentioned this pull request Jan 14, 2022

releases: add TiDB 5.4.0 release notes pingcap/docs-cn#8061

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cluster: fix the bug that region statistics are not updated after flow-round-by-digit change #4304

cluster: fix the bug that region statistics are not updated after flow-round-by-digit change #4304

HunDunDM commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021 •

edited

Loading

codecov bot commented Nov 8, 2021 •

edited

Loading

nolouch left a comment

HunDunDM commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 12, 2021

cluster: fix the bug that region statistics are not updated after flow-round-by-digit change #4304

cluster: fix the bug that region statistics are not updated after flow-round-by-digit change #4304

Conversation

HunDunDM commented Nov 8, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Nov 8, 2021 • edited Loading

codecov bot commented Nov 8, 2021 • edited Loading

Codecov Report

nolouch left a comment

Choose a reason for hiding this comment

HunDunDM commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 8, 2021

ti-chi-bot commented Nov 12, 2021

ti-chi-bot commented Nov 8, 2021 •

edited

Loading

codecov bot commented Nov 8, 2021 •

edited

Loading