Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile cloud features with 6.4.tikv branch #182

Merged
merged 2 commits into from
Aug 1, 2020
Merged

Compile cloud features with 6.4.tikv branch #182

merged 2 commits into from
Aug 1, 2020

Conversation

de-sh
Copy link

@de-sh de-sh commented Jul 25, 2020

Used in PR tikv/rust-rocksdb#517 and #181

Adds code used in compiling with rocksdb~6.4.tikv along with rocksdb~6.4.cloud

Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
@de-sh de-sh changed the title Rework to be used in rust-rocksdb Compile cloud features with 6.4.tikv branch Jul 25, 2020
yiwu-arbug pushed a commit that referenced this pull request Jul 27, 2020
Related to tikv/rust-rocksdb#517 and #182
### Summary
Adds code used in compiling with [rocksdb~6.4.tikv](https://github.com/tikv/rocksdb/tree/6.4.tikv) along with [rocksdb~6.4.cloud](https://github.com/tikv/rocksdb/tree/6.4.cloud)

### Changes
- Makes public the struct LogReporter so that it can be accessed by [rocksdb~6.4.cloud/cloud/manifest_reader.cc#L114](https://github.com/tikv/rocksdb/blob/6a7c514453e3e3e1c3bb57c18d8e0280089ccdcd/cloud/manifest_reader.cc#L114)

Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Copy link
Collaborator

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiwu-arbug yiwu-arbug merged commit ac0e18f into tikv:6.4.cloud Aug 1, 2020
@de-sh de-sh deleted the 6.4.cloud branch August 2, 2020 11:06
tabokie pushed a commit to tabokie/rocksdb that referenced this pull request May 12, 2022
Related to tikv/rust-rocksdb#517 and tikv#182
Adds code used in compiling with [rocksdb~6.4.tikv](https://github.com/tikv/rocksdb/tree/6.4.tikv) along with [rocksdb~6.4.cloud](https://github.com/tikv/rocksdb/tree/6.4.cloud)

- Makes public the struct LogReporter so that it can be accessed by [rocksdb~6.4.cloud/cloud/manifest_reader.cc#L114](https://github.com/tikv/rocksdb/blob/6a7c514453e3e3e1c3bb57c18d8e0280089ccdcd/cloud/manifest_reader.cc#L114)

Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie pushed a commit that referenced this pull request May 12, 2022
Related to tikv/rust-rocksdb#517 and #182
Adds code used in compiling with [rocksdb~6.4.tikv](https://github.com/tikv/rocksdb/tree/6.4.tikv) along with [rocksdb~6.4.cloud](https://github.com/tikv/rocksdb/tree/6.4.cloud)

- Makes public the struct LogReporter so that it can be accessed by [rocksdb~6.4.cloud/cloud/manifest_reader.cc#L114](https://github.com/tikv/rocksdb/blob/6a7c514453e3e3e1c3bb57c18d8e0280089ccdcd/cloud/manifest_reader.cc#L114)

Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants