avoid unnecessary live file query and fix double referencing moved file #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
|
Sorry for delay, will get to this today or tomorrow. |
Connor1996
reviewed
Jun 30, 2021
| void Ref() { ++refs; } | ||
|
|
||
| bool Unref() { | ||
| --refs; |
There was a problem hiding this comment.
How about making ref be private?
tabokie
commented
Jul 1, 2021
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
|
Looking good overall. Let's send to upstream and see? |
|
duplicated with #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabokie xy.tao@outlook.com
Obsolete file candidates consist of
obsolete_files_that are no longer referenced by any version inVersionSet, and all files in DB directory ifdoing_full_scanis true. By design,obsolete_files_is guaranteed to be obsolete and thus no need to be checked against live files list. This PR avoids the unnecessary live file query when not doing full scan.The optimization depends on the assumption that each physical SST file is represented by an unique
FileMetaDatastructure, which is actually broken in existing codebase: A trivial file move will create a new file meta for the same file number. This patch also fix this issue.