tweak(Calendar/Model/Event): use Tinebase_Exception_SystemGeneric for…

… rrule until validation fail ... we don't need this in sentry (user input)
tine-groupware · Sep 10, 2024 · 01c8346 · 01c8346
1 parent 224112a
commit 01c8346
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tests/tine20/Calendar/Controller/RecurTest.php b/tests/tine20/Calendar/Controller/RecurTest.php
@@ -38,8 +38,8 @@ public function testInvalidRruleUntil()
             'container_id'  => $this->_getTestCalendar()->getId(),
         ));
 
-        $this->expectException('Tinebase_Exception_Record_Validation');
-        $persistentEvent = $this->_controller->create($event);
+        $this->expectException(Tinebase_Exception_SystemGeneric::class);
+        $this->_controller->create($event);
     }
 
     /**

diff --git a/tine20/Calendar/Model/Event.php b/tine20/Calendar/Model/Event.php
@@ -896,7 +896,8 @@ public function setRruleUntil()
         }
 
         if ($this->rrule_until && $this->rrule_until->getTimeStamp() - $this->dtstart->getTimeStamp() < -1) {
-            throw new Tinebase_Exception_Record_Validation('rrule until must not be before dtstart');
+            $translation = Tinebase_Translation::getTranslation(Calendar_Config::APP_NAME);
+            throw new Tinebase_Exception_SystemGeneric($translation->_('Until has to be after event start'));
         }
     }
     public static function resetFreeBusyCleanupCache()