fix(Tinebase/User): make account blocking work again

tine-groupware · Sep 17, 2024 · 4d99a24 · 4d99a24
1 parent 4704af3
commit 4d99a24
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/tests/tine20/Tinebase/ControllerServerTest.php b/tests/tine20/Tinebase/ControllerServerTest.php
@@ -158,8 +158,6 @@ public function testInvalidLogin()
      */
     public function testAccountBlocking()
     {
-        self::markTestSkipped('FIXME account should be blocked? or test can be removed');
-
         // NOTE: end transaction here as NOW() returns the start of the current transaction in pgsql
         //  and is used in user status statement (think about using statement_timestamp() instead of NOW() with pgsql)
         Tinebase_TransactionManager::getInstance()->commitTransaction($this->_transactionId);

diff --git a/tests/tine20/Tinebase/User/SqlTest.php b/tests/tine20/Tinebase/User/SqlTest.php
@@ -155,11 +155,10 @@ public function testSetStatusEnabled()
 
     /**
      * try to enable an account
+     *
      */
     public function testUserIsBlocked()
     {
-        self::markTestSkipped('FIXME account should be blocked? or test can be removed');
-
         // add a test user (enabled by default)
         $testUser = $this->testAddUser();
 

diff --git a/tine20/Tinebase/Setup/setup.xml b/tine20/Tinebase/Setup/setup.xml
@@ -233,7 +233,7 @@
         </table>
         <table>
             <name>accounts</name>
-            <version>19</version>
+            <version>20</version>
             <declaration>
                 <field>
                     <name>id</name>
@@ -313,8 +313,8 @@
                 </field>
                 <field>
                     <name>login_failures</name>
-                    <type>integer</type>
-                    <default>0</default>
+                    <type>text</type>
+                    <length>4000</length>
                 </field>
                 <field>
                     <name>last_login_failure_at</name>