Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to resolve the command injection vulnerability. #62

Merged
merged 2 commits into from Jul 13, 2017
Merged

Fix to resolve the command injection vulnerability. #62

merged 2 commits into from Jul 13, 2017

Conversation

keymandll
Copy link
Contributor

No description provided.

@cristianstaicu
Copy link

Great pull request! I hope it gets accepted! ;)

@deiga
Copy link
Collaborator

deiga commented Jul 10, 2017

@tj Any way you could get this merged and released? :)
It's not fun to just ignore security warnings https://nodesecurity.io/advisories/146

@tj
Copy link
Owner

tj commented Jul 10, 2017

I don't use node anymore, happy to add someone as maintainer.

@deiga
Copy link
Collaborator

deiga commented Jul 11, 2017

@tj I'll volunteer to take the torch, even though I've not been a contributor to this project

@tj
Copy link
Owner

tj commented Jul 11, 2017

grr can't sign into npm haha, so annoying having a separate registry, should have you added in a min

@tj
Copy link
Owner

tj commented Jul 11, 2017

k there we go, added!

@ronkorving
Copy link

Please merge and release this :) We have security alerts going off in both retire and nsp modules.

@deiga deiga merged commit d71177d into tj:master Jul 13, 2017
@deiga
Copy link
Collaborator

deiga commented Jul 13, 2017

@keymandll Did you test if this works? When running node tests.js I get an error with Spawn

@laserlemon
Copy link

@tj, @deiga 👋 Hello! I'm a GitHub staff member on the team responsible for sending security vulnerability alerts based on CVE reports. CVE-2017-16042 states that versions 1.10.0 and 1.10.1 of growl are vulnerable, although it seems as though this fix was merged prior to release of version 1.10.0. Could you please let me know the vulnerable/secure status of versions 1.10.0 and 1.10.1 with respect to this specific vulnerability?

Please reply as soon as possible. If we don't hear back within ~24 hours, we'll send alerts based on our best determination. Thank you!! ❤️ :octocat:

@deiga
Copy link
Collaborator

deiga commented Jun 8, 2018

@laserlemon You observed correctly that from 1.10.0 onwards growl should not be vulnerable to CVE-2017-16042 anymore.
Why that report exists is beyond me, frankly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants