Revert "Improve performance by binding copycat keys just once" #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6bcd4dc. It broke the once fixed issue with Yank (tmux-plugins#121), causing a regression. To ensure this was the problematic commit, I checked out its parent (ca3d52d) and it's working fine there, so I suggest we revert the broken commit. In summary (check the link above for details), this commit breaks Tmux scrolling completely, and after getting into scrolling no keys will work, so you can't leave scrolling. Only workaround I found was killing `tmux-server`. Conflicts: scripts/copycat_mode_bindings.sh. I fixed the conflict and tested that it can select tokens/URLs, that I can scroll with it (which I couldn't before this reversion). I'm not sure it won't introduce bugs, but it definitely fixes the regression mentioned above. I don't have much experience with this codebase, so I'm wondering if @gpanders (original committer) if they could assist on fixing this commit and re-reverting. Thanks.
kurko
commented
Dec 27, 2020
|
|
||
| unbind_all_bindings() { | ||
| grep -v copycat <"${TMPDIR:-/tmp}/copycat_$(whoami)_recover_keys" | while read -r key_cmd; do | ||
| sh -c "tmux $key_cmd" |
kurko
referenced
this pull request
Dec 27, 2020
All of the copycat scripts check to make sure we're in copycat mode, and if we're not they are essentially a no-op. This means we can safely leave the keys bound to those scripts even when we're not in copycat mode. The benefit of this is that we don't have to bind and unbind the keys every time we enter or leave copycat mode, which helps improve performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6bcd4dc. It broke the once
fixed issue with Yank (#121),
causing a regression. To ensure this was the problematic commit, I checked out
its parent (ca3d52d) and it's working fine
there, so I suggest we revert the broken commit.
In summary (check the link above for details), this commit breaks Tmux scrolling
completely, and after getting into scrolling no keys will work, so you can't
leave scrolling. Only workaround I found was killing
tmux-server.Conflicts: scripts/copycat_mode_bindings.sh. I fixed the conflict and tested
that it can select tokens/URLs, that I can scroll with it (which I couldn't
before this reversion). I'm not sure it won't introduce bugs, but it definitely
fixes the regression mentioned above.
I don't have much experience with this codebase, so I'm wondering if @gpanders
(original committer) if they could assist on fixing this commit and
re-reverting. Thanks.