refactor(edgeless): element tree manager #8239
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a21a0ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
L-Sun
changed the title
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
818cecd
to
a21a0ac
Compare
| @@ -134,6 +144,10 @@ export abstract class GfxPrimitiveElementModel< | |||
| return true; | |||
| } | |||
|
|
|||
| get container() { | |||
There was a problem hiding this comment.
What's the difference between group and container?
There was a problem hiding this comment.
The contianer() can return block contianer like frame. And some codes of group relation watcher will be migrated to tree manager watcher
Closes: [BS-1398](https://linear.app/affine-design/issue/BS-1398/[bug]-拖出-frame-后-mindmap-依然跟随-frame), [BS-1400](https://linear.app/affine-design/issue/BS-1400/mindmap无法移出frame) This PR fix mindmap is moved with frame moving when the mindmap has been drag out of frame. ### What changes - add workround to avoid multiple container in `FrameManager` for nodes of mindmap. - The fix can be refactored after #8239 - add frame and mindmap e2e tests
No description provided.