Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: deprecate env_logger in favor of tracing_subscriber::fmt::Subscriber #2752

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

davidbarsky
Copy link
Member

Continuation of the plan outlined in #2750.

(Note that this is intentionally not targeting the master branch, as we'll just remove env_logger feature there.)

@davidbarsky davidbarsky requested review from hawkw and a team as code owners October 12, 2023 23:45
@davidbarsky davidbarsky enabled auto-merge (squash) October 12, 2023 23:45
@davidbarsky
Copy link
Member Author

CI is failing on this PR since it needs to be rebased atop of #2751.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm whenever the branches this depends on are merged!

@davidbarsky davidbarsky merged commit 11aac9a into v0.1.x Oct 12, 2023
33 of 53 checks passed
@davidbarsky davidbarsky deleted the davidbarsky/deprecate-env-logger-in-tracing-log branch October 12, 2023 23:58
@davidbarsky
Copy link
Member Author

...uh, I'm not sure why this merged. That wasn't intentional.

@hawkw
Copy link
Member

hawkw commented Oct 13, 2023

wait, why didn't we want to merge this one?

hawkw added a commit that referenced this pull request Oct 23, 2023
# 0.1.4 (October 23rd, 2023)

### Changes

- Deprecated `env_logger` feature in favor of 
  `tracing_subscriber::fmt::Subscriber` (#2752)

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.1.4 (October 23rd, 2023)

### Changes

- Deprecated `env_logger` feature in favor of 
  `tracing_subscriber::fmt::Subscriber` (tokio-rs#2752)

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants