chore(infra): Share some properties across workspace #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@louisfd doesn't fully centralize version (because of inter deps), but should help already a bit |
|
@dcvz This is a great idea! I guess you should update with |
# Conflicts: # backend-comparison/Cargo.toml # burn-autodiff/Cargo.toml # burn-candle/Cargo.toml # burn-common/Cargo.toml # burn-compute/Cargo.toml # burn-core/Cargo.toml # burn-dataset/Cargo.toml # burn-derive/Cargo.toml # burn-fusion/Cargo.toml # burn-import/Cargo.toml # burn-import/onnx-tests/Cargo.toml # burn-ndarray/Cargo.toml # burn-no-std-tests/Cargo.toml # burn-tch/Cargo.toml # burn-tensor-testgen/Cargo.toml # burn-tensor/Cargo.toml # burn-train/Cargo.toml # burn-wgpu/Cargo.toml # burn/Cargo.toml # examples/custom-renderer/Cargo.toml # examples/custom-training-loop/Cargo.toml # examples/custom-wgpu-kernel/Cargo.toml # examples/guide/Cargo.toml # examples/image-classification-web/Cargo.toml # examples/mnist-inference-web/Cargo.toml # examples/mnist/Cargo.toml # examples/named-tensor/Cargo.toml # examples/onnx-inference/Cargo.toml # examples/text-classification/Cargo.toml # examples/text-generation/Cargo.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 85.55% 85.58% +0.02%
==========================================
Files 508 508
Lines 53910 53910
==========================================
+ Hits 46122 46138 +16
+ Misses 7788 7772 -16 ☔ View full report in Codecov by Sentry. |
|
@nathanielsimard updated! |
nathanielsimard
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed version bumping touches many places, this is an attempt to alleviate that a bit.