Allow multiple pattern matches in chain with PyTorchFileRecorder
#1269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks all
script has been executed.Changes
Changed the record
remap
function to allow multiple pattern matches in chain when using thePyTorchFileRecorder
For example, I initially though that providing multiple patterns like this would remap the keys on each match:
but it does not. Instead it
break
s at the first match.Stumbled upon this when trying to import the pre-trained ResNet-18 weights from torchvision for my implementation here.
In the residual blocks, we sometimes have a downsample layer that requires more than one portion of the key to be remapped (hence the patterns in chain). For example,
layer1.0.downsample.0.*
should be remapped tolayer1.blocks.0.downsample.conv.*
, which can be decomposed with the patterns presented in the example above.