Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

BRAKING CHANGE: refactor render function #323

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Conversation

kamiazya
Copy link
Member

@kamiazya kamiazya commented May 24, 2021

What was a problem

  • It was unclear how to use the IContext interface, which is the second argument of the render function.

How this PR fixes the problem

Fix render and renderToDot functions

Fixed the second argument of the render function to give a cluster that will be a container instead of the IContext interface.

-function render(element: ReactElement, context?: IContext): number;
+function render(element: ReactElement, container?: ICluster): ICluster;

Fix useNode and useEdge API

Check lists (check x in [ ] of list items)

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

{Please write here}

@kamiazya kamiazya marked this pull request as ready for review July 22, 2021 06:43
@kamiazya kamiazya merged commit 0f77406 into main Jul 22, 2021
@kamiazya kamiazya deleted the fix-render-function branch July 22, 2021 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant