Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Html like labels #62

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Html like labels #62

merged 2 commits into from
Apr 23, 2020

Conversation

kamiazya
Copy link
Member

@kamiazya kamiazya commented Apr 23, 2020

What was a problem

It was possible to describe an HTML Like label in the label attribute using the JSX notation, but there was a problem that the type hint could not be obtained because the standard HTML table element was already defined.

How this PR fixes the problem

Expanded JSX.IntrinsicElements so that HTML Like label in DOT can be described as follows.

<Node
  id="nodeA"
  shape="none"
  label={
    <DOT.TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
      <DOT.TR>
        <DOT.TD>left</DOT.TD>
        <DOT.TD PORT="m">middle</DOT.TD>
        <DOT.TD PORT="r">right</DOT.TD>
      </DOT.TR>
    </DOT.TABLE>
  }
/>

@kamiazya kamiazya added the enhancement New feature or request label Apr 23, 2020
@kamiazya kamiazya merged commit 93a3acf into master Apr 23, 2020
@kamiazya kamiazya deleted the html-like branch April 23, 2020 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant