This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Fix Graphviz component api #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was a problem
If the Web Module is rendered in ReactDOM at once, an error will be output if there is no context.
How this PR fixes the problem
When bundled, the NoContext variable was divided into multiple files and the judgment could not be done normally.
Graphviz component can also be imported from
@ts-graphviz/react.Check lists (check
xin[ ]of list items)Additional Comments (if any)
Fixed the unnatural part in the error wording.
Cannot call useGraphvizContext outside GraphvizContext. -Cannot call useGraphvizContext outside context. Basically, you need to use the render function provided by @ts-graphviz/react.