Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: support .dropdown-item wrapped in <li> tags #33649

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

cpsievert
Copy link
Contributor

Backports #33634 into v4

@cpsievert cpsievert requested review from a team as code owners April 15, 2021 15:23
@cpsievert cpsievert changed the base branch from main to v4-dev April 15, 2021 15:24
cpsievert added a commit to rstudio/bslib that referenced this pull request Apr 15, 2021
cpsievert added a commit to rstudio/bslib that referenced this pull request Apr 15, 2021
@cpsievert cpsievert mentioned this pull request Apr 15, 2021
2 tasks
@XhmikosR
Copy link
Member

Let's wait until the main PR has landed and this one's tests pass.

@XhmikosR XhmikosR marked this pull request as draft April 16, 2021 05:50
js/tests/unit/tab.js Outdated Show resolved Hide resolved
@cpsievert

This comment has been minimized.

@XhmikosR XhmikosR marked this pull request as ready for review April 21, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants