Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_custom-forms.scss: fix order of attributes #36231

Merged
merged 1 commit into from
May 14, 2022

Conversation

twin-elements
Copy link

Wrong order of attributes

Wrong order of attributes
@twin-elements twin-elements requested a review from a team as a code owner April 26, 2022 09:08
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.
Even if the order in this case doesn't matter since it works both ways, IMHO it still brings more consistency in the v4 source code; borders are always defined as width then style then color in other files.
Note for maintainters: Label (and project reference) should be v4 instead of v5

@mdo mdo added v4 and removed v5 labels Apr 28, 2022
@XhmikosR XhmikosR changed the title Update _custom-forms.scss _custom-forms.scss: fix order of attributes May 14, 2022
@XhmikosR XhmikosR merged commit d9481ee into twbs:v4-dev May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants