Clean up the build and fix some tests

[johnynek]

We migrated the tests long ago from scalacheck driven to scalatest driven.

We missed some of the correct conversion so some of the tests are no-op.

Side note, I pretty much hate how flexible scalatest is. It is very difficult to see if something is a no-op. This have been disabled for years.

Probably more are also but I didn't run them down yet.

[johnynek]

@piyushnarang can you review this?

[codecov-io]

Codecov Report

Merging #272 into develop will increase coverage by 5.51%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
+ Coverage    66.14%   71.65%   +5.51%     
===========================================
  Files           50       50              
  Lines         1397     1397              
  Branches        50       50              
===========================================
+ Hits           924     1001      +77     
+ Misses         473      396      -77

Impacted Files	Coverage Δ
...c/main/scala/com/twitter/bijection/Injection.scala	48.21% <0%> (+3.57%)	⬆️
...a/com/twitter/bijection/CollectionBijections.scala	46.57% <0%> (+6.84%)	⬆️
...a/com/twitter/bijection/CollectionInjections.scala	96.77% <0%> (+16.12%)	⬆️
...cala/com/twitter/bijection/NumericInjections.scala	85.13% <0%> (+27.02%)	⬆️
...cala/com/twitter/bijection/NumericBijections.scala	100% <0%> (+58.13%)	⬆️
.../scala/com/twitter/bijection/ModDivInjection.scala	100% <0%> (+76.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72af31f...d773b14. Read the comment docs.

[johnynek]

+5.5% coverage! woot!

@ianoc or @sriramkrishnan can you folks give me a +1 on this? Pretty safe: just fixes some broken tests and adds some more.

[ianoc]

very nice! +5.5% is a decent jump!

[piyushnarang]

👍