Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added list handling for hard fname swaps #1

Merged
merged 2 commits into from
May 15, 2019
Merged

added list handling for hard fname swaps #1

merged 2 commits into from
May 15, 2019

Conversation

JuanHuaXu
Copy link

ditto

@tylerwince
Copy link
Owner

tylerwince commented May 15, 2019 •
edited
Loading

I feel like doing something like ["<stdin>" if x=="-" else x for x in new_files_list] is better. Maintains order if there (for whatever reason) happens to be other files in the list and is more pythonic.

@JuanHuaXu
Copy link
Author

you are right, let me fix and test

@tylerwince tylerwince merged commit 10c6378 into tylerwince:495-cannot-seek-stdin-on-pipe May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerwince tylerwince tylerwince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanHuaXu @tylerwince @cat-code