Fix types in CI by updating lockfile #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were ending up with drift between `@types/ember` and its transitive `@types/ember__routing` dependency. The usual practical/experiential reason to get the heck off of `@types` entirely everywhere.
This was referenced Oct 25, 2022
(cherry picked from commit 06dd9fd)
chriskrycho
force-pushed
the
fix-ci-types
branch
from
180fc9b
to
c390b72
Compare
The former directly and the latter transitively. Wheeeee.
|
All right, the remaining issues here are gated on making a breaking change release, so I am going to land this and the others like it, cut a final minor release with these changes, then cut a v6.0 release which drops support for Node 12, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were ending up with drift between
@types/emberand its transitive@types/ember__routingdependency. The usual practical/experiential reason to get the heck off of@typesentirely everywhere.Closes #1528 (by including it!).