Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use Node 14+ (drop support for Node 12) #1533

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Update to use Node 14+ (drop support for Node 12) #1533

merged 1 commit into from
Oct 25, 2022

Conversation

chriskrycho
Copy link
Member

  • in volta key in package.json
  • in config for Windows CI in ci.yml

@chriskrycho
Update to use Node 14+
7e00a06 
- in `volta` key in `package.json`
- in config for Windows CI in `ci.yml`
@chriskrycho chriskrycho added the BREAKING This is a breaking change! Do not merge without major version release. label Oct 25, 2022
@chriskrycho
Copy link
Member Author

All right, landing this because it lets proceed with Ember CLI fixes (of which there is actually one, likely because of a transitive dependency change or some such, but it was made invisible by the Node 14 issues previously).

@chriskrycho chriskrycho merged commit ff45eb8 into master Oct 25, 2022
@chriskrycho chriskrycho deleted the node-version-bump branch October 25, 2022 19:09
@chriskrycho chriskrycho mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BREAKING This is a breaking change! Do not merge without major version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chriskrycho