Avoid eviction on entry replacement #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`*Result` objects are immutable, thus if a `PartialResult` gets filled further it has to be re-set into the cache. This does not change the cache size, but because the current S3 and SIEVE implementations unconditionally check the cache size on `__setitem__` they may evict an entry unnecessarily. Fix that: if there is already a valid cache entry for the key, just update it in place instead of trying to evict then creating a brand new entry. Also update the LRU to pre-check for size (and presence as well), this may make setting a bit more expensive than post-check but it avoids "wronging" the user by bypassing the limit they set. Fixes ua-parser#201
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Mar 28, 2024
Partial results are back-filled (new domains added) by re-setting them in the cache. With a sufficiently incorrect implementation, the cache can evict entries on that occasion even though it does not need to (because we're replacing an existing entry). Exactly that should have been fixed by ua-parser#204, but was not tested at the time. Fixes ua-parser#199
Open
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Mar 30, 2024
Partial results are back-filled (new domains added) by re-setting them in the cache. With a sufficiently incorrect implementation, the cache can evict entries on that occasion even though it does not need to (because we're replacing an existing entry). Exactly that should have been fixed by ua-parser#204, but was not tested at the time. Fixes ua-parser#199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Resultobjects are immutable, thus if aPartialResultgets filled further it has to be re-set into the cache.This does not change the cache size, but because the current S3 and SIEVE implementations unconditionally check the cache size on
__setitem__they may evict an entry unnecessarily.Fix that: if there is already a valid cache entry for the key, just update it in place instead of trying to evict then creating a brand new entry.
Also update the LRU to pre-check for size (and presence as well), this may make setting a bit more expensive than post-check but it avoids "wronging" the user by bypassing the limit they set.
Fixes #201