Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag list in gcs backend #197

Merged
merged 5 commits into from
Aug 2, 2019
Merged

Fix tag list in gcs backend #197

merged 5 commits into from
Aug 2, 2019

Conversation

evelynl94
Copy link
Collaborator

@evelynl94 evelynl94 commented Aug 2, 2019

seeing this

{
  "name": "kraken/test",
  "tags": [
    "link",
    "link",
    "link",
    "link",
    "link",
    "link",
    "link"
  ]
}

we are missing c.pather.NameFromBlobPath(b) after list from gcs.

Also created #198 to follow up.

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #197 into master will increase coverage by 0.03%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   66.52%   66.56%   +0.03%     
==========================================
  Files         183      183              
  Lines        9049     9056       +7     
==========================================
+ Hits         6020     6028       +8     
+ Misses       2254     2252       -2     
- Partials      775      776       +1
Impacted Files Coverage Δ
lib/backend/gcsbackend/client.go 41.91% <61.53%> (+3.15%) ⬆️
core/peer_info.go 88.88% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2c8d2...124bbdb. Read the comment docs.

@evelynl94 evelynl94 merged commit 128c7e2 into master Aug 2, 2019
@evelynl94 evelynl94 deleted the evelynl94-patch-2 branch August 2, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants